[REL] Matching Set Perk Fix

Post » Thu Jul 26, 2012 9:59 pm

Matching Set Perk Fix

Author: Chesko

Contact: Forums - Chesko
E-mail - chesko.tesmod@gmail.com




Download


http://skyrim.nexusmods.com/mods/21129

http://steamcommunity.com/sharedfiles/filedetails/?id=85312121


Description

This simple plugin improves the conditions in which you receive certain bonuses related to matching sets of gear.

Due to some rather flimsy condition logic, many matching set-style bonuses and perks can fail to be applied correctly when using certain mods. Chances are, if you're using "Cloaks of Skyrim" by Nikinoodles, or "Winter is Coming - Cloaks" by Nivea (both truly excellent mods), or other mods that add wearable equipment outside of the standard 4 "head hands feet body", you are probably experiencing this problem and may not even realize it. Other armor and worn equipment mods are possible avenues of experiencing this issue as well. Bethesda did not account for the possibility that the player might wear more than 4 pieces of gear with the same material keyword when they designed these perks and bonuses.

The Problem


The issue stems from how Bethesda designed their condition functions related to Matching Set, Custom Fit, Well Fitted, and so on, perks and bonuses. They read like the following:
  • WornApparelHasKeywordCount ArmorMaterialHide == 4 OR
  • WornApparelHasKeywordCount ArmorMaterialLeather == 4 OR
  • WornApparelHasKeywordCount ArmorMaterialElven == 4 OR
  • WornApparelHasKeywordCount ArmorMaterialGlass == 4 OR...
  • etc
What this means is that, to receive this bonus, you must be wearing a combination of gear where that keyword appears EXACTLY 4 times. This means, if you're wearing a Cloak from Cloaks of Skyrim or Winter is Coming, this condition will fail, since these mods use the ArmorMaterialLeather or ArmorMaterialHide keywords (your total keyword count will be 5 and the perk will fail to apply).

A major reason an author might want to use these keywords is to ensure that they are sorted properly in the Tanning Rack / Smithing crafting menus. Or, an author simply might want to facilitate enchanting their gear. I think these are very good reasons, and the mod author should not be penalized for doing this.

Either way, this mod rectifies this problem to ensure you always get the correct bonus even if the original armor / equipment author utilizes these keywords.

The Solution


I simply changed the logic to read like the following:
  • WornApparelHasKeywordCount ArmorMaterialHide >= 4 OR
  • WornApparelHasKeywordCount ArmorMaterialLeather >= 4 OR
  • WornApparelHasKeywordCount ArmorMaterialElven >= 4 OR
  • WornApparelHasKeywordCount ArmorMaterialGlass >= 4 OR...
  • etc
When using this mod, to receive this bonus, you must be wearing a combination of gear where that keyword appears 4 OR MORE times, which is a lot more inclusive. Other perks / bonuses have been edited in a similar fashion.

Perks and Bonuses Affected By This Mod

  • Matching Set Perk (Light Armor)
  • Matching Set Perk (Heavy Armor)
  • Custom Fit Perk (Light Armor)
  • Well Fitted Perk (Heavy Armor)
  • Nightingale Armor Full Set
  • Shrouded Armor Full Set

Forms Affected By This Mod

  • PERK: CustomFit
  • PERK: WellFitted
  • PERK: MatchingSet
  • PERK: MatchingSetHeavy
  • SPELL: PerkMatchingSet
  • SPELL: PerkMatchingSetHeavy
  • SPELL: PerkCustomFit
  • SPELL: PerkWellFitted
  • SPELL: TGFullSet
  • SPELL: DBFullSet

Compatibility


Directly incompatible with perk overhauls, balance mods, etc, that alter the specific forms mentioned above. If you want to ensure this mod's changes always take effect, load it lower in your load order than these mods.

Known Issues


You will receive the Matching Set bonuses when you have at least 4 pieces of gear with the same material keyword. This means you could, for instance, wear Hide Boots, Hide Gloves, Hide Helmet, and a Hide cloak from Winter is Coming and still receive the bonus without body armor. This is against the intention of this perk, but still better than not receiving the bonus at all. The logic may be further improved in the future to account for this.

Troubleshooting


"I installed the mod but it didn't seem to work. I am using other Perk-affecting mods."
Ensure that this mod loads lower than your perk, balance, or overhaul mods.

Thanks


Thanks to Amethyst Deceiver for the list of perks and spells that needed to be fixed, as well as for bringing this issue to my attention.

Let me know if you have any issues. Enjoy!
User avatar
Amy Cooper
 
Posts: 3400
Joined: Thu Feb 01, 2007 2:38 am

Post » Fri Jul 27, 2012 3:37 am

Crap....while this sounds interesting, I can tell just from reading that this will conflict with Helmless Warrior, which changes the armor perks to require only 3 pieces of armor, rather than 4.

Is there any way to make these two play nice with each other, or are we going to be stuck with one or the other?
User avatar
Jessica Stokes
 
Posts: 3315
Joined: Fri Jul 28, 2006 11:01 am

Post » Thu Jul 26, 2012 9:05 pm

I don't have any intention of supporting that, no. The primary intent of this is to allow the bonus to apply when wearing 4 or more pieces of gear of the same material, such as when wearing a cloak.
User avatar
jodie
 
Posts: 3494
Joined: Wed Jun 14, 2006 8:42 pm

Post » Fri Jul 27, 2012 1:55 am

Unfortunate.....though maybe loading Helmless Warrior afterwards would work - this changes the condition to ">=4 OR", and then loading Helmless Warrior, which only changes the number would change it to ">=3 OR".
User avatar
Betsy Humpledink
 
Posts: 3443
Joined: Wed Jun 28, 2006 11:56 am

Post » Fri Jul 27, 2012 12:46 am

Crap....while this sounds interesting, I can tell just from reading that this will conflict with Helmless Warrior, which changes the armor perks to require only 3 pieces of armor, rather than 4.

Is there any way to make these two play nice with each other, or are we going to be stuck with one or the other?
Perhaps you could check that the author of HW knows about this? It wouldn't be that difficult for them to change their conditions to >= would it?
User avatar
Sophie Miller
 
Posts: 3300
Joined: Sun Jun 18, 2006 12:35 am

Post » Fri Jul 27, 2012 3:58 am

Unfortunate.....though maybe loading Helmless Warrior afterwards would work - this changes the condition to ">=4 OR", and then loading Helmless Warrior, which only changes the number would change it to ">=3 OR".
I can't see how it only changes the number... I'd assume it changes the condition of the perk entirely. For that matter, this will conflict with perk mods, but it's simple enough for them to replicate the changes.
User avatar
darnell waddington
 
Posts: 3448
Joined: Wed Oct 17, 2007 10:43 pm

Post » Fri Jul 27, 2012 2:34 am

I can't see how it only changes the number... I'd assume it changes the condition of the perk entirely. For that matter, this will conflict with perk mods, but it's simple enough for them to replicate the changes.

I always assumed it only changed the number, since it just bumps the armor requirement down from 4 to 3 for the perk to take effect (and changes the perk text to reflect this).

I highly doubt this mod would conflict would the only other perk mod I use, Perk Freedom, which lets me just take perks as I want as long as I have the skill, rather than having to take crappy perks like Fists of Steel.
User avatar
Shannon Lockwood
 
Posts: 3373
Joined: Wed Aug 08, 2007 12:38 pm

Post » Fri Jul 27, 2012 3:05 am

I'll be out of pocket for a couple of hours, so I'll try to answer any questions not already answered by others in the thread when I get back. Thanks.
User avatar
Francesca
 
Posts: 3485
Joined: Thu Jun 22, 2006 5:26 pm

Post » Fri Jul 27, 2012 11:43 am

I don't think it's a magnitude type thing, where you can just change the number... By all means, try your method, or look it up in the CK.
It shouldn't conflict with that kind, no. I was meaning those that alter perk trees.

(also, do you mean contact, rather than pocket, Chesko?)
User avatar
Gavin boyce
 
Posts: 3436
Joined: Sat Jul 28, 2007 11:19 pm


Return to V - Skyrim