Hi!

So, I've been going back and replacing a bunch of game.getPlayer() calls with a PlayerRef property, because it's more efficient.

However, despite the property being set to the PlayerRef(00000014) in the CK, once the script is running, the property seems to be a NONE. The following error (and more like it) appear in my Papyrus logs:

[11/11/2012 - 03:35:06AM] error: Cannot call HasMagicEffect() on a None object, aborting function callstack:[Active effect 7 on  (00000014)].ishicobattlemageweaponbuffscript.OnSpellCast() - "ishicobattlemageweaponbuffscript.psc" Line 56

Am I doing something wrong? Forgetting something?

Can I see the entire script, please?

Scriptname ishicobattlemageweaponbuffscript extends activemagiceffect  {script to apply weapon damage buff when spell is cast}MagicEffect Property buffEffect1  AutoMagicEffect Property buffEffect2  AutoMagicEffect Property buffEffect3  AutoMagicEffect Property buffEffect4  AutoMagicEffect Property buffEffect5  AutoSpell Property buffSpell1  AutoSpell Property buffSpell2  AutoSpell Property buffSpell3  AutoSpell Property buffSpell4  AutoSpell Property buffSpell5  AutoMagicEffect Property dispelEffect1  AutoMagicEffect Property dispelEffect2  AutoMagicEffect Property dispelEffect3  AutoMagicEffect Property dispelEffect4  AutoMagicEffect Property dispelEffect5  AutoSpell Property dispelSpell1  AutoSpell Property dispelSpell2  AutoSpell Property dispelSpell3  AutoSpell Property dispelSpell4  AutoSpell Property dispelSpell5  AutoSpell Property rampdownSpell1  AutoSpell Property rampdownSpell2  AutoSpell Property rampdownSpell3  AutoSpell Property rampdownSpell4  Auto Actor Property playerRef AutoEvent OnSpellCast(Form akSpell)Spell castSpell = akSpell as SpellIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect1) == 0 && playerRef.hasMagicEffect(buffEffect2) == 0 && playerRef.hasMagicEffect(buffEffect3) == 0 && playerRef.hasMagicEffect(buffEffect4) == 0 && playerRef.hasMagicEffect(buffEffect5) == 0buffSpell1.cast(playerRef, playerRef)debug.trace("buff 1 applied!")ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect1) == 1buffSpell2.cast(playerRef, playerRef)debug.trace("buff 2 applied!")ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect2) == 1buffSpell3.cast(playerRef, playerRef)debug.trace("buff 3 applied!")ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect3) == 1buffSpell4.cast(playerRef, playerRef)debug.trace("buff 4 applied!")ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect4) == 1buffSpell5.cast(playerRef, playerRef) debug.trace("buff 5 applied!")ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(buffEffect5) == 1buffSpell5.cast(playerRef, playerRef)EndIfIf castSpell.getPerk() != None && playerRef.hasMagicEffect(dispelEffect5) == 1rampdownSpell4.cast(playerRef, playerRef)ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(dispelEffect4) == 1rampdownSpell3.cast(playerRef, playerRef)ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(dispelEffect3) == 1rampdownSpell2.cast(playerRef, playerRef)ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(dispelEffect2) == 1rampdownSpell1.cast(playerRef, playerRef)ElseIf castSpell.getPerk() != None && playerRef.hasMagicEffect(dispelEffect1) == 1playerRef.dispelSpell(rampdownSpell1)EndIfEndEvent 

Thanks, did you try to use a Debug.Messagebox? Maybe the error comes from the logging and it actually works ingame? Or maybe you need a new save for the changes to be successfully applied?

The script failed to work before I added the debug tracing... I added those lines to see if that part of the script was firing at all. The error with "hasMagicEffect() cannot be called on a NONE object" occurs on the first If line, before the script even gets to the debug trace calls.

That I might need a new save didn't occur to me. I'll try that now.

Nope, loaded the save, no change :<

Damn
That's strange, because you said you filled the properties... Are you using a modified Update.esm? I had an issue with one of my mods that caused all my properties to be set to NULL, and I think it was because I modded this file to be compatible with the Creation Kit...

Removed post

I thought Events received by ObjectReference would also be received by ActiveMagicEffect?

I cleaned Update.esm with TES5Edit, but other than that I haven't touched it.

The property definitely says it's set in the CK. Is there any way to make sure it's set elsewhere (in Edit or anything)?

ActiveMagicEffects receive all the events that the ObjectReference they're active on receives, yes.

[EDIT] And though I think it's understood, I didn't say it clearly, so... the script worked perfectly fine when I was using a variable and a getPlayer() call. It's only since replacing those with the Property that the script has stopped working.

Really, really strange behaviour... Could you test it on someone else's computer?

No :/

Aaand, I just removed the property, declared playerRef as an actor variable to game.getPlayer(), made no other changes... the script works perfectly.

Well, it looks like your ActiveMagicEffect does not like this particular property... That's strange, maybe it gets removed after the effect is no more on the player? That'd be lame though