Hey ppl.

I am trying to get the following script to work:


Scriptname myweaponscript extends activemagiceffect

int weaponvalue = http://forums.bethsoft.com/topic/1351312-script-works-except-for-one-flaw/100

Event OnEffectStart(Actor Target, Actor Caster) ;; script triggers on every hit
weaponvalue = http://forums.bethsoft.com/topic/1351312-script-works-except-for-one-flaw/weaponvalue - 10 ;; on every hit the value has 10 removed from it (this does not happen when it should)

if weaponvalue =http://forums.bethsoft.com/topic/1351312-script-works-except-for-one-flaw/= 0 ;; when the value reaches 0 it executes a command
wepdrop.show() ;; shows a message (property)
endif
EndEvent


The script does exactly what it should do with 1 exeption, on every hit a value (weaponvalue) is supposed to have 10 removed from it (starts at 100) but this doesn't seem to happen, anyone have any ideas why?

Magic scripts do NOT store the value from one run to the next.
You would have to use a global variable to store any values you want to keep track of.

Awwww that svcks.

Is their any way to create a temporary global?

You could use a token (an unplayable, therefore invisible, piece of armour) or the rank of a faction you create for this purpose to store some extra data on an actor that would persist between instances of your magic effect, and be accessible from your script.

Cipscis

Explain please?

He's saying you can fake a global variable, by abusing for example a faction rank (an integer value) or create a non-playable/invisible item and attach a script to that.

Using tokens is what I did before but unfortunately didn't work out, its the reason I am using scripted enchantments instead which works perfectly except for that 1 private variable issue.

How would the faction rank thing work? (example)

I never abused anything yet, but from the looks of Faction.psc you can use Get/Set/ModReaction(), you just have to create a new faction.
Since that will undoubtedly result in ugly and weird code, you should use a custom property (with getter and setter) to hide that ugliness.

surely this should be an on-hit event? and because the magic effect that has this script is applied to the player actor- it can reference a varaible atatched to it?

OnHit only applies to a source that can actually be hit which is only actors.

http://www.creationkit.com/OnHit_-_ObjectReference should work for all http://www.creationkit.com/ObjectReference_Script. Although only http://www.creationkit.com/Actor_Script would be affected by a magic effect, all ObjectReferences will register that they've been hit.

Cipscis

Using global variable is rather simple, and makes more sense than using a faction. Its the same work and process to use a global.

1. Create >Miscellaneous >Global object. Like 'myInputGlobalName'.
2. Attach property of 'global' to your script using the name you gave the global for the auto-fill to work.
3. get your global variable with:
float myVal = myInputGlobalName.GetValue()
Now the local variable 'myVal' will contain your global value.
4. set your global variable with:
myInputGlobalName.SetValue(1)

Thanks for the help guys but I got the script working regardless, it turned out that when the weapon was unequipped it wasn't accounting for the fact that you may be dual-wielding thus threw everything out of whack. I had to add an unequip command under a OnUnequip event (lol).