Alchemy Sorter Script not working : V - Skyrim

» Tue Jun 19, 2012 7:03 pm

Sounds like you did assign them properly. Maybe it's like tunaisafish said, and you just need to make a clean save.

» Wed Jun 20, 2012 12:25 am

Well, technically I don't see anything wrong with the script. I re-wrote it a bit while investigating, here's the result.

Spoiler

scriptname DTOMSorterScript extends ObjectReference{A script to sort Alchemicals into REF jars};///////////////////////////////////////////////////////////////////////////// / Properties /////////////////////////////////////////////////////////////////////////////;Sound property QSTAstrolabeButtonPressX auto;Ingredient property MS03BlackBriarSecretIngredient auto;ObjectReference property MS03BlackBriarSecretIngredientCHESTREF autoIngredient property AntlersLarge autoIngredient property AntlersSmall autoIngredient property BearClaws autoIngredient property BeeHiveHusk autoIngredient property BeeHoneyComb autoIngredient property BirdEgg01 autoIngredient property BirdEgg02 autoIngredient property BirdEgg03 autoIngredient property BoneMeal autoIngredient property BriarHeart autoIngredient property CanisRoot01 autoIngredient property CharredSkeeverHide autoIngredient property ChaurusEggs autoIngredient property CreepClusterRoot autoIngredient property CritterBeelngredient autoIngredient property CritterPondFish01Ingredient autoIngredient property CritterPondFish02Ingredient autoIngredient property CritterPondFish03Ingredient autoIngredient property CritterPondFish041ngredient autoIngredient property CritterPondFish05Ingredient autoIngredient property DaedraHeart autoIngredient property DBJarrinRoot autoIngredient property deathbell autoIngredient property DragonflyBlue autoIngredient property DragonflyOrange AutoIngredient property DragonsTongue autoIngredient property DwarvenOil autoIngredient property Ectoplasm autoIngredient property ElvesEar autoIngredient property FalmerEar autoIngredient property FavorThadgeirAshes autoIngredient property FirefryThorax autoIngredient property FireSalts autoIngredient property FrostMirriam autoIngredient property FrostSalts autoIngredient property Garlic autoIngredient property GiantLichen autoIngredient property GiantToes autoIngredient property glowDust autoIngredient property GlowingMushroom autoIngredient property HagravenClaw autoIngredient property HagravenFeathers autoIngredient property HangingMoss autoIngredient property HawkBeak autoIngredient property HawkFeathers autoIngredient property HumanFlesh autoIngredient property HumanHeart autoIngredient property IceWraithTeeth autoIngredient property JazBay autoIngredient property JuniperBerries autoIngredient property Lavender autoIngredient property MoonSugar autoIngredient property MoraTapinellaBits autoIngredient property MothWingBlue autoIngredient property MothWingLuna autoIngredient property MothWingMonarch autoIngredient property MountainFlower01Blue autoIngredient property MountainFlower01Purple autoIngredient property MountainFlower01Red autoIngredient property MudcrabChitin autoIngredient property Mushroom01 autoIngredient property Mushroom02 autoIngredient property Mushroom03 autoIngredient property Mushroom04 autoIngredient property Mushroom05 autoIngredient property Mushroom06 autoIngredient property Nightshade autoIngredient property NimrootRed autoIngredient property Nirnroot autoIngredient property NordicBarnacles autoIngredient property Pearl AutoIngredient property PearlSmall autoIngredient property PowderedMammothTusk autoIngredient property SabrecatEyeball autoIngredient property SabrecatTooth autoIngredient property SaltPile autoIngredient property ScalyPholiotaBits autoIngredient property SkeeverTail autoIngredient property SlaughterfishEgg01 autoIngredient property SlaughterfishScales autoIngredient property Snowberry autoIngredient property SpiderEgg autoIngredient property SpikyGrass01 autoIngredient property SprigganSap autoIngredient property SwampFungalPod01 autoIngredient property Taproot autoIngredient property Thistle01 autoIngredient property TrollFat autoIngredient property TundraCotton autoIngredient property vampireDust autoIngredient property VoidSalts autoIngredient property Wheat autoIngredient property WispWrappings autoObjectReference property AntlersLargeCHESTREF2 autoObjectReference property AntlersSmallCHESTREF autoObjectReference property BearClawsCHESTREF autoObjectReference property BeeHiveHuskCHESTREF autoObjectReference property BeeHoneyCombCHESTREF autoObjectReference property BirdEgg01CHESTREF autoObjectReference property BirdEgg02CHESTREF autoObjectReference property BirdEgg03CHESTREF autoObjectReference property BoneMealCHESTREF autoObjectReference property BriarHeartCHESTREF autoObjectReference property CanisRoot01CHESTREF autoObjectReference property CharredSkeeverHideCHESTREF autoObjectReference property ChaurusEggsCHESTREF autoObjectReference property CreepClusterRootCHESTREF autoObjectReference property CritterBeelngredientCHESTREF autoObjectReference property CritterPondFish01IngredientCHESTREF autoObjectReference property CritterPondFish02IngredientCHESTREF autoObjectReference property CritterPondFish03IngredientCHESTREF autoObjectReference property CritterPondFish041ngredientCHESTREF autoObjectReference property CritterPondFish05IngredientCHESTREF autoObjectReference property DaedraHeartCHESTREF autoObjectReference property DBJarrinRootCHESTREF autoObjectReference property deathbellCHESTREF autoObjectReference property DragonflyBlueCHESTREF autoObjectReference property DragonflyOrangeCHESTREF autoObjectReference property DragonsTongueCHESTREF autoObjectReference property DwarvenOilCHESTREF autoObjectReference property EctoplasmCHESTREF autoObjectReference property ElvesEarCHESTREF autoObjectReference property FalmerEarCHESTREF autoObjectReference property FavorThadgeirAshesCHESTREF autoObjectReference property FirefryThoraxCHESTREF autoObjectReference property FireSaltsCHESTREF autoObjectReference property FrostMirriamCHESTREF autoObjectReference property FrostSaltsCHESTREF autoObjectReference property GarlicCHESTREF autoObjectReference property GiantLichenCHESTREF autoObjectReference property GiantToesCHESTREF autoObjectReference property glowDustCHESTREF autoObjectReference property GlowingMushroomCHESTREF autoObjectReference property HagravenClawCHESTREF autoObjectReference property HagravenFeathersCHESTREF autoObjectReference property HangingMossCHESTREF autoObjectReference property HawkBeakCHESTREF autoObjectReference property HawkFeathersCHESTREF autoObjectReference property HumanFleshCHESTREF autoObjectReference property HumanHeartCHESTREF autoObjectReference property IceWraithTeethCHESTREF autoObjectReference property JazBayCHESTREF autoObjectReference property JuniperBerriesCHESTREF autoObjectReference property LavenderCHESTREF autoObjectReference property MoonSugarCHESTREF autoObjectReference property MoraTapinellaBitsCHESTREF autoObjectReference property MothWingBlueCHESTREF autoObjectReference property MothWingLunaCHESTREF autoObjectReference property MothWingMonarchCHESTREF autoObjectReference property MountainFlower01BlueCHESTREF autoObjectReference property MountainFlower01PurpleCHESTREF autoObjectReference property MountainFlower01RedCHESTREF autoObjectReference property MudcrabChitinCHESTREF autoObjectReference property Mushroom01CHESTREF autoObjectReference property Mushroom02CHESTREF autoObjectReference property Mushroom03CHESTREF autoObjectReference property Mushroom04CHESTREF autoObjectReference property Mushroom05CHESTREF autoObjectReference property Mushroom06CHESTREF autoObjectReference property NightshadeCHESTREF autoObjectReference property NimrootRedCHESTREF autoObjectReference property NirnrootCHESTREF autoObjectReference property NordicBarnaclesCHESTREF autoObjectReference property PearlCHESTREF autoObjectReference property PearlSmallCHESTREF autoObjectReference property PowderedMammothTuskCHESTREF autoObjectReference property SabrecatEyeballCHESTREF autoObjectReference property SabrecatToothCHESTREF autoObjectReference property SaltPileCHESTREF autoObjectReference property ScalyPholiotaBitsCHESTREF autoObjectReference property SkeeverTailCHESTREF autoObjectReference property SlaughterfishEgg01CHESTREF autoObjectReference property SlaughterfishScalesCHESTREF autoObjectReference property SnowberryCHESTREF autoObjectReference property SpiderEggCHESTREF autoObjectReference property SpikyGrass01CHESTREF autoObjectReference property SprigganSapCHESTREF autoObjectReference property SwampFungalPod01CHESTREF autoObjectReference property TaprootCHESTREF autoObjectReference property Thistle01CHESTREF autoObjectReference property TrollFatCHESTREF autoObjectReference property TundraCottonCHESTREF autoObjectReference property vampireDustCHESTREF autoObjectReference property VoidSaltsCHESTREF autoObjectReference property WheatCHESTREF autoObjectReference property WispWrappingsCHESTREF auto;///////////////////////////////////////////////////////////////////////////// / Events /////////////////////////////////////////////////////////////////////////////;event OnCellAttach()	PlayAnimation("Open")endeventevent OnActivate(ObjectReference akActionRef)	Actor player = Game.GetPlayer()	if (akActionRef != player)		return	endif	PlayAnimationAndWait("Trigger01", "done")	if (QSTAstrolabeButtonPressX)		QSTAstrolabeButtonPressX.Play(self)	endif	; TryTransfer(MS03BlackBriarSecretIngredient, player, MS03BlackBriarSecretIngredientCHESTREF)	TryTransfer(AntlersLarge, player, AntlersLargeCHESTREF2)	TryTransfer(AntlersSmall, player, AntlersSmallCHESTREF)	TryTransfer(BearClaws, player, BearClawsCHESTREF)	TryTransfer(BeeHiveHusk, player, BeeHiveHuskCHESTREF)	TryTransfer(BeeHoneyComb, player, BeeHoneyCombCHESTREF)	TryTransfer(BirdEgg01, player, BirdEgg01CHESTREF)	TryTransfer(BirdEgg02, player, BirdEgg02CHESTREF)	TryTransfer(BirdEgg03, player, BirdEgg03CHESTREF)	TryTransfer(BoneMeal, player, BoneMealCHESTREF)	TryTransfer(BriarHeart, player, BriarHeartCHESTREF)	TryTransfer(CanisRoot01, player, CanisRoot01CHESTREF)	TryTransfer(CharredSkeeverHide, player, CharredSkeeverHideCHESTREF)	TryTransfer(ChaurusEggs, player, ChaurusEggsCHESTREF)	TryTransfer(CreepClusterRoot, player, CreepClusterRootCHESTREF)	TryTransfer(CritterBeelngredient, player, CritterBeelngredientCHESTREF)	TryTransfer(CritterPondFish01Ingredient, player, CritterPondFish01IngredientCHESTREF)	TryTransfer(CritterPondFish02Ingredient, player, CritterPondFish02IngredientCHESTREF)	TryTransfer(CritterPondFish03Ingredient, player, CritterPondFish03IngredientCHESTREF)	TryTransfer(CritterPondFish041ngredient, player, CritterPondFish041ngredientCHESTREF)	TryTransfer(CritterPondFish05Ingredient, player, CritterPondFish05IngredientCHESTREF)	TryTransfer(DaedraHeart, player, DaedraHeartCHESTREF)	TryTransfer(DBJarrinRoot, player, DBJarrinRootCHESTREF)	TryTransfer(deathBell, player, deathBellCHESTREF)	TryTransfer(DragonflyBlue, player, DragonflyBlueCHESTREF)	TryTransfer(DragonflyOrange, player, DragonflyOrangeCHESTREF)	TryTransfer(DragonsTongue, player, DragonsTongueCHESTREF)	TryTransfer(DwarvenOil, player, DwarvenOilCHESTREF)	TryTransfer(Ectoplasm, player, EctoplasmCHESTREF)	TryTransfer(ElvesEar, player, ElvesEarCHESTREF)	TryTransfer(FalmerEar, player, FalmerEarCHESTREF)	TryTransfer(FavorThadgeirAshes, player, FavorThadgeirAshesCHESTREF)	TryTransfer(FirefryThorax, player, FirefryThoraxCHESTREF)	TryTransfer(FireSalts, player, FireSaltsCHESTREF)	TryTransfer(FrostMirriam, player, FrostMirriamCHESTREF)	TryTransfer(FrostSalts, player, FrostSaltsCHESTREF)	TryTransfer(Garlic, player, GarlicCHESTREF)	TryTransfer(GiantLichen, player, GiantLichenCHESTREF)	TryTransfer(GiantToes, player, GiantToesCHESTREF)	TryTransfer(glowDust, player, glowDustCHESTREF)	TryTransfer(GlowingMushroom, player, GlowingMushroomCHESTREF)	TryTransfer(HagravenClaw, player, HagravenClawCHESTREF)	TryTransfer(HagravenFeathers, player, HagravenFeathersCHESTREF)	TryTransfer(HangingMoss, player, HangingMossCHESTREF)	TryTransfer(HawkBeak, player, HawkBeakCHESTREF)	TryTransfer(HawkFeathers, player, HawkFeathersCHESTREF)	TryTransfer(HumanFlesh, player, HumanFleshCHESTREF)	TryTransfer(HumanHeart, player, HumanHeartCHESTREF)	TryTransfer(IceWraithTeeth, player, IceWraithTeethCHESTREF)	TryTransfer(JazBay, player, JazBayCHESTREF)	TryTransfer(JuniperBerries, player, JuniperBerriesCHESTREF)	TryTransfer(Lavender, player, LavenderCHESTREF)	TryTransfer(MoonSugar, player, MoonSugarCHESTREF)	TryTransfer(MoraTapinellaBits, player, MoraTapinellaBitsCHESTREF)	TryTransfer(MothWingBlue, player, MothWingBlueCHESTREF)	TryTransfer(MothWingLuna, player, MothWingLunaCHESTREF)	TryTransfer(MothWingMonarch, player, MothWingMonarchCHESTREF)	TryTransfer(MountainFlower01Blue, player, MountainFlower01BlueCHESTREF)	TryTransfer(MountainFlower01Purple, player, MountainFlower01PurpleCHESTREF)	TryTransfer(MountainFlower01Red, player, MountainFlower01RedCHESTREF)	TryTransfer(MudcrabChitin, player, MudcrabChitinCHESTREF)	TryTransfer(Mushroom01, player, Mushroom01CHESTREF)	TryTransfer(Mushroom02, player, Mushroom02CHESTREF)	TryTransfer(Mushroom03, player, Mushroom03CHESTREF)	TryTransfer(Mushroom04, player, Mushroom04CHESTREF)	TryTransfer(Mushroom05, player, Mushroom05CHESTREF)	TryTransfer(Mushroom06, player, Mushroom06CHESTREF)	TryTransfer(Nightshade, player, NightshadeCHESTREF)	TryTransfer(NimrootRed, player, NimrootRedCHESTREF)	TryTransfer(Nirnroot, player, NirnrootCHESTREF)	TryTransfer(NordicBarnacles, player, NordicBarnaclesCHESTREF)	TryTransfer(Pearl, player, PearlCHESTREF)	TryTransfer(PearlSmall, player, PearlSmallCHESTREF)	TryTransfer(PowderedMammothTusk, player, PowderedMammothTuskCHESTREF)	TryTransfer(SabrecatEyeball, player, SabrecatEyeballCHESTREF)	TryTransfer(SabrecatTooth, player, SabrecatToothCHESTREF)	TryTransfer(SaltPile, player, SaltPileCHESTREF)	TryTransfer(ScalyPholiotaBits, player, ScalyPholiotaBitsCHESTREF)	TryTransfer(SkeeverTail, player, SkeeverTailCHESTREF)	TryTransfer(SlaughterfishEgg01, player, SlaughterfishEgg01CHESTREF)	TryTransfer(SlaughterfishScales, player, SlaughterfishScalesCHESTREF)	TryTransfer(Snowberry, player, SnowberryCHESTREF)	TryTransfer(SpiderEgg, player, SpiderEggCHESTREF)	TryTransfer(SpikyGrass01, player, SpikyGrass01CHESTREF)	TryTransfer(SprigganSap, player, SprigganSapCHESTREF)	TryTransfer(SwampFungalPod01, player, SwampFungalPod01CHESTREF)	TryTransfer(Taproot, player, TaprootCHESTREF)	TryTransfer(Thistle01, player, Thistle01CHESTREF)	TryTransfer(TrollFat, player, TrollFatCHESTREF)	TryTransfer(TundraCotton, player, TundraCottonCHESTREF)	TryTransfer(vampireDust, player, vampireDustCHESTREF)	TryTransfer(VoidSalts, player, VoidSaltsCHESTREF)	TryTransfer(Wheat, player, WheatCHESTREF)	TryTransfer(WispWrappings, player, WispWrappingsCHESTREF)endevent;///////////////////////////////////////////////////////////////////////////// / Functions /////////////////////////////////////////////////////////////////////////////;function TryTransfer(Ingredient what, ObjectReference from, ObjectReference to)	;DEBUG BEGIN	if (what == none || from == none || to == none)		Debug.Trace("DTOMSorterScript: FAIL, see stacktrace")	endif	;DEBUG END	int count = from.GetItemCount(what)	if (count > 0)		from.RemoveItem(what, count, true)		to.AddItem(what, count, true)	endifendfunction

I can only sign on to the idea from tunaisafish - old invalid property, causing you this trouble.

» Wed Jun 20, 2012 2:58 am

Nice re-write

I'm hoping it is an old save issue, otherwise I'm lost lol.

It's one thing for modders to learn to use a clean save when testing, but imagine the mayhem when this kind of weirdness turns up in endusers games.
I'm beginning to think it might be worth putting a watchdog script in to enforce clean saves everytime you release an update.

» Tue Jun 19, 2012 7:45 pm

Both My own and Xetril's script run perfectly. With Xetril's permission I'd like to use his solution as it's a more efficient.
But a huge thanks to everyone. I've got a few tweaks to make, like removing quest items etc but the script works.
Hooray, I have an Alchemy Sorter.

» Wed Jun 20, 2012 8:47 am

Of course, do whatever you want. Just glad it works because like usual with these things, I didn't test anything

.

» Wed Jun 20, 2012 2:17 am

Of course, do whatever you want. Just glad it works because like usual with these things, I didn't test anything :biggrin:

.

Again thanks
Just as a matter of curiosity and to help me learn
If a take the TryTransfer code

TryTransfer(AntlersLarge, player, AntlersLargeCHESTREF2)

and swap it over in a new script

TryTransfer(AntlersLarge, AntlersLargeCHESTREF2,player)

Will this transfer stored ingredients back to the player.

» Tue Jun 19, 2012 7:50 pm

Yep.