I have made a ability that attaches to the player a magiceffect through some conditions


the game handles everything correcly: the ability shows/hides in UI as expected, and the debug notification is correct.

But when I check if the magic effect is on the player with

game.getplayer().hasmagiceffect(myTestAbility)

, the game always return true.

what I am missing here...? The effect is still on the player even if it has finished? If yes, what is the correct method to check if it is active?

Erm, I think it's amazing you managed to get that to work in the activemagiceffect script.. I could only get the thing to work in the actor script.

But one way to check is do this:

if game.getplayer().hasmagiceffect(myTestAbility);do stuffendif

the property is already in, and correctly set in esp too. (otherwise that would return false anyway)

this is exactly what I am doing, but what I am saying if that game.getplayer().hasmagiceffect(myTestAbility) always returns true.

(edit, crap, I added a post instead of editing the previous one, sorry)

Pretty sure that is not supposed to happen. I am mostly using hasmagiceffectwithkeyword, and that works as it should.

What are the parameters of your magic effect (Fire&Forget, Self etc.)?
Is it a custom made effect or did you use one that is already in place?
Does the spell applying the Effect have any other effects attached? Are any of those still running?

He's using a magic effect attached to an ability. There was a topic by kuertee describing how to use this to check for conditions not available through scripting commands (the example used was GetPC1stPerson).

My guess is that the script only triggers the OnEffectStart when the magic effect becomes active and triggers OnEffectFinish when it becomes inactive. Probably HasMagicEffect doesn't care whether or not the effect is currently active, just whether or not you have it at all.

yes this is the same idea
this is exactly what I am thinking...:
there is no way to simply check directly if the effect is active or not in that case...
I've finally solved the problem with a quest Script that handle the magiceffect response.

is "myTestAbility" a magic effect or an ability? If it is an ability, it will always return true because the ability will always be present on the player until you manually remove it. The magic effect attached to the ability is what switches on and off with your conditions.
So

game.getplayer().hasmagiceffect(myMagicEffect)

should be what you're after. (where "myMagicEffect" is the effect attached to the ability)

myTestAbility is only the name I gave to the property, but it's linked to the magicEffect (It's not possible to link a magicEffect property to a spell anyway.)

I think you have a rogue effect on your player that's perhaps not in the UI. Have you checked your uses on the MGEF and see if there's more than one spell that might be using it? This .... appears ... to work for me. Although come to think of it, I apply some of my MGEFs in a very unique way when I have to use abilities. Since you have a workaround, I won't go into it, but if you want to know PM me and I'll respond here.

-MM

@mofomojo
Yes, I was thinking about this but I am pretty sure I have only one spell using the MGEF. And I am also completly sure the "spell-ability" is applied once to the player (and not in a onUpdate or onInit event). This is really wierd.

So I ran across this problem with magic effect archetypes being "thought" to be applied by the game when I was implementing sun damage for my vampirism mod. I had an ability that applied health damage. The spell conditions only applied the effect if the player was outside and the lightlevel was greater than a certain value, but in the game, even when I wasn't taking damage the engine *thought* I was and wouldn't let me fast travel, sleep, or wait. To work around the problem I implemented the following workaround....so...it is possible if you have an ability that only applies effects under certain conditions, the game will always think the player has the effect even if the conditions are not TRUE and the effect isn't actually applied. Stupid I know.

1) Create a spell with necessary conditions for effect
2) Create an effect for the spell which adds a perk
3) Have the perk apply another spell
4) Have the spell use an actual MGEF that applies whatever effect you need to test for your conditions

That should work to dynamically add/remove the proper effect you need to test for. Stinks that it has to be so complicated. Alternatively...I can't recall if I ever tested having the required conditions on BOTH the SPELL and the EFFECT and getting by with one spell. The thought hadn't actually crossed my mind until I read your post since I haven't thought about this problem for 3-4 months (I started my mod with SkyEdit).

-MM

@mofomojo
Thank for the tips. My method is a bit different a works quite good ad far as I know:

1) Create a spell with necessary conditions for effect
2) Create 2 effect for the spell. One with a condition and one for the opposite condition (condition == 1) and (condition != 1)
3) attach a script to each effect that set a variable to true or false (depending of the conditions logic) in their onEffect Start event (I dont trust the onEffectStop, this is why I use 2 effects)

Then you just have to check the variable value.
In my case I stored the variable in a Quest script (where I also put some functions that I use as a small personnal api)
but that would also probably work with adding/removing perk, or with a globalvariable.

Very good! There's always more than one way, and we learn when we see about new tecgniques.