Depends how you play. I personally, as a warrior, like my follower to be a warrior class. If I have sword/shield, then I either have my follower with a Greatsword or the same as me. Why? Well...
1. Both Greatswords: tank out that bandit lair.
2. Both Sword and Shield: tactical elimination, and we always War Tortoise with the shields, so we're untouched by arrows on our approach.
3. Different weapons: Mix things up, make the enemies rethink their attack.