Player.RemoveSpell() Not Working : V

» Tue Jun 19, 2012 7:11 am

I have the following code:

Spoiler

Scriptname SIMSChooseConjuration extends activemagiceffectMessage Property MyMessage AutoSpell Property Familiar AutoSpell Property Skeleton AutoSpell Property RaiseDead AutoSpell Property BoundSword AutoSpell Property this AutoActor playerevent OnEffectStart(actor target, actor caster);menu code goes here;something likeplayer = Game.GetPlayer()if caster == playerint res;int choicewhile res != 5 ;im assuming your third button is the one you want to stop onres = MyMessage.show()if res == 0player.addSpell(Familiar)player.unequipSpell(this, 0)player.removeSpell(this)res = 5elseif res == 1player.addSpell(Skeleton)player.unequipSpell(this, 0)player.removeSpell(this)res = 5elseif res == 2player.addSpell(RaiseDead)player.unequipSpell(this, 0)player.removeSpell(this)res = 5elseif res == 3player.addSpell(BoundSword)player.unequipSpell(this, 0)player.removeSpell(this)res = 5elseif res == 4res = 5endifUtility.wait(0.8)endwhileendifendevent

But the spell doesn't get removed from the player's inventory. Everything else works. Any ideas??

If not I'll just change it an object and have the player equip that.

EDIT: No idea why it isn't formatting properly.

» Tue Jun 19, 2012 7:21 am

player.removeSpell(this)

It's probably because of the ''this''. Because the script is attached to a magic effect, the ''this'' refers to the magic effect and not the spell. Instead you should try:

player.removeSpell(player.getEquippedSpell(hand))

Now the only problem with that is that you don't know in which hand the player has the spell equipped.. so would probably need to use player.GetEquippedItemType(hand) once for each hand to see whether he has spells equipped or something... and maybe require more checks to see whether he has the correct spell equipped, not sure.

» Mon Jun 18, 2012 11:33 pm

But the spell doesn't get removed from the player's inventory. Everything else works. Any ideas??

If not I'll just change it an object and have the player equip that.

EDIT: No idea why it isn't formatting properly.

You connected the property `this` to whatever spell you are wanting to remove? I don't see anywhere in the code that it is being set so maybe you should verify the value of it with a debug message. Also it looks like you want to break out of the menu no matter what the user picks. You can just comment out the while and endwhile lines to achieve the same effect.

» Mon Jun 18, 2012 9:22 pm

Near the start of the code (line 8)

Spell Property this Auto

And thanks for the tip about the while loop. I had problems with it showing up before without a while loop but I'll give it a go

.

» Tue Jun 19, 2012 2:16 am

Near the start of the code (line 8)

Spell Property this Auto

And thanks for the tip about the while loop. I had problems with it showing up before without a while loop but I'll give it a go :biggrin:

.

Yes but this only declares a property for the script. You have to give that property a value by connecting it to the spell you want in the CK. Right now it's basically an allocated empty spell. The tutorial has nice pictures of how to do this: http://www.creationkit.com/Bethesda_Tutorial_Papyrus_Introduction_to_Properties_and_Functions#Properties

» Tue Jun 19, 2012 7:34 am

I have connected that to a spell, but perhaps the problem is the spell I am trying to remove is the one the player is casting? The lines that unequip the spell work, but the spell stays in the inventory.

» Tue Jun 19, 2012 3:43 am

Ah never mind my initial reply, was confused with programming languages like Java where ''this'' is a reserved word

Not sure why it doesn't work then

» Tue Jun 19, 2012 7:57 am

I have connected that to a spell, but perhaps the problem is the spell I am trying to remove is the one the player is casting? The lines that unequip the spell work, but the spell stays in the inventory.

Ah that is a possibility then.. Maybe you could use a scroll? It would destroy itself after casting

Try

Event OnEffectEnd()  player.removespell(this)EndEvent

» Mon Jun 18, 2012 9:18 pm

Ah never mind my initial reply, was confused with programming languages like Java where ''this'' is a reserved word

Not sure why it doesn't work then

Yeah I program in java too and I thought it would be the same (until I realised the magiceffect is not the spell that needs to be removed)

» Mon Jun 18, 2012 8:46 pm

Ah that is a possibility then.. Maybe you could use a scroll? It would destroy itself after casting

Try

Event OnEffectEnd()  player.removespell(this)EndEvent

Good idea on the scroll front, that should solve it. I also tried the OnEffectEnd but that didn't work. Scroll it is

.

» Mon Jun 18, 2012 5:55 pm

I actually havnt gotten removespell to work either for some reason, I just use duractions for spells that need to be removed.

» Mon Jun 18, 2012 10:59 pm

I do know that the Papyrus version of AddPerk() simply refuses to work for adding perks to anything other than the player. So I wouldn't be surprised if other functions also fail to work as expected in some cases. Maybe that's the case with RemoveSpell().

» Tue Jun 19, 2012 2:44 am

What hand do you have the spell equipped to?

You're unequipping from 0. That's only the left hand. If it's possible to equip the spell on either hand, you could also try adding a unequipspell(this, 1) to your code.

» Mon Jun 18, 2012 11:24 pm

The unequip bit worked (as it was equipped in the left hand), it's just trying to remove the spell didn't work.