I'm playing around with a small function that should set two characters into a fist fight within a Scene.

For the actual script I have this:

;BEGIN FRAGMENT CODE - Do not edit anything between this and the end comment;NEXT FRAGMENT INDEX 1Scriptname TIF__0202C1B1 Extends TopicInfo HiddenFunction FightStart(Actor NPC1, Actor NPC2)   NPC1.SetLookAt(NPC2, true)   NPC2.SetLookAt(NPC1, true)   NPC1.GetActorBase().SetInvulnerable(true)   NPC2.GetActorBase().SetInvulnerable(true)   NPC1.StartCombat(NPC2)   NPC2.StartCombat(NPC1)EndFunction;END FRAGMENT CODE - Do not edit anything between this and the begin commentReferenceAlias Property Alias_Glathor  Auto  ReferenceAlias Property Alias_Engar  Auto

And the call to the FightStart function, which is placed in the End fragment of the dialog in the scene is:

FightStart(Alias_Glathor.GetActorReference(), Alias_Engar.GetActorReference())

The error I am getting is:

FightStart is not a function or does not exist

What am I doing wrong?

Thanks for any and all help

I don't think a function inside a fragment will work.
It's easier (and better I think) to add a property to the fragment and then call your function located in another script.

MyScript Property Call Auto

In your fragment:

Call.FightStart(Alias_Glathor.GetActorReference(), Alias_Engar.GetActorReference())

What is MyScript?

I get an error for it

Thanks!

Was I supposed to put "MyScript Property Call Auto" into the script of the fragment?

"Myscript" is a placeholder for the actual scriptname of the script where you have written the function to be called.

Yes, open the frament in the script editor and add it below the "Do Not Edit" comments.

Because you're adding a script property, you will not be able to add it using the Properties button.

But you DO fill it with the button, it won't auto fill but it should show the quest it extends in the drop down box.

The name of the script that Ingenue created for the mod is called "LBGQ30fistfight", which pretty much only holds the function....FightStart(Actor NPC1, Actor NPC2)

So, in the fragment source I would add something like "LBGQ30fistfight Property Call Auto"?

Meh

Adding "LBGQ30fistfight Property Call Auto" to the fragment source didn't make them fight

I would add a debug.messagebox in the function to verify it is being called.
It may be that you also need to add the alias properties to the fragment as well. idk.
I do know this method does work in a quest fragment - I assume it would work in an object fragment.
I use it extensively in one of my mods.

The function isn't being called....drats!

Here's the script contents:

Scriptname LBGQ30fistfight extends ObjectReferenceFunction FightStart(Actor NPC1, Actor NPC2)debug.messagebox("Fight Works!")   NPC1.SetLookAt(NPC2, true)   NPC2.SetLookAt(NPC1, true)   NPC1.GetActorBase().SetInvulnerable(true)   NPC2.GetActorBase().SetInvulnerable(true)   NPC1.StartCombat(NPC2)   NPC2.StartCombat(NPC1)EndFunctionAlias Property Alias_Engar  Auto  Alias Property Alias_Glathor  Auto

And the fragment is "Call.FightStart(Alias_Glathor.GetActorReference(), Alias_Engar.GetActorReference())"

In the fragment source I added the line "LBGQ30fistfight Property Call Auto"

Do you have script logging enabled? Maybe that could help show what's going on.

I wonder if you also need to add the alias properties to the fragment as well...

How is this fragment triggered?

If you want to make your life easier:

• Place your normal script containing your function into the regular Scripts area for your quest and fill in all the properties that need filling.
  
• Go to the Stage fragment you want to call your function in, place a semicolon in the box.
  
• Open the dropdown box for kMyQuest, and select the script containing your function.
  
• Compile the fragment and exit.
  
• Return to your fragment, and type in "kMyQuest.()", and recompile.

This will have the CK make a property reference to the script containing the function you want to use for you.

Looking at the current function he's trying to access, it is not attached to a quest.

You can't do that. I tried with linking an ActiveMagicEffect script to a Quest script for variable transfer before now, and it just didn't work. Check the Properties window, if you find you are unable to give that property a specific value, what you are attempting is impossible. You have to contain your function in a Quest script if you want to use it in your quest's fragments or call it from another quest.

I haven't tried your suggestions yet but would the problem not be because I am calling the fight to start during the scene when other NPCs are saying their dialog?

But I wouldn't be able to call the function within the scene, right?

Here is a screenshot of the part of the scene where I want the fight to start. It shows the dialog "What did you just say?" and the fragment where I've been trying to get the fight to start:

http://lamplight.pcgamingnetwork.com/viewtopic.php?f=2&t=29

I get the error "... cannot cast a quest to a lbgq30fistfight, types are incompatible" when I try this

As I said above, what you are trying to do will not work. Only Quest scripts can be used in the manner both myself and aellis described. Yours is not, so you will need to find another method.

I'd suggest removing the Function altogether and just calling everything up in the TopicInfo script loose. No need to be overly complex:

;BEGIN FRAGMENT CODE - Do not edit anything between this and the end comment;NEXT FRAGMENT INDEX 1Scriptname TIF__0202C1B1 Extends TopicInfo Hidden   Alias_Glathor.GetActorReference().SetLookAt(Alias_Engar.GetActorReference(), true)   Alias_Engar.GetActorReference().SetLookAt(Alias_Glathor.GetActorReference(), true)   Alias_Glathor.GetActorBase().SetInvulnerable(true)   Alias_Engar.GetActorBase().SetInvulnerable(true)   Alias_Glathor.GetActorReference().StartCombat(Alias_Engar.GetActorReference())   Alias_Engar.GetActorReference().StartCombat(Alias_Glathor.GetActorReference());END FRAGMENT CODE - Do not edit anything between this and the begin commentReferenceAlias Property Alias_Glathor  Auto  ReferenceAlias Property Alias_Engar  Auto

"calling everything up in the TopicInfo script loose"

Sorry, I don't understand

See the code snippet I added in. I mean just get rid of the Function()/EndFunction lines and put everything inside of it into your specific Topic result fragment that triggers the fight.

I have this where it will compile:

;BEGIN FRAGMENT CODE - Do not edit anything between this and the end comment;NEXT FRAGMENT INDEX 2Scriptname TIF__0202C1B1 Extends TopicInfo Hidden   Alias_Glathor.GetActorReference().SetLookAt(Alias_Engar.GetActorReference(), true)   Alias_Engar.GetActorReference().SetLookAt(Alias_Glathor.GetActorReference(), true)   Alias_Glathor.GetActorBase().SetInvulnerable(true)   Alias_Engar.GetActorBase().SetInvulnerable(true)   Alias_Glathor.GetActorReference().StartCombat(Alias_Engar.GetActorReference())   Alias_Engar.GetActorReference().StartCombat(Alias_Glathor.GetActorReference())T;END FRAGMENT CODE - Do not edit anything between this and the begin commentReferenceAlias Property Alias_Glathor  Auto  ReferenceAlias Property Alias_Engar  Auto

But how would I call that to start the fight?

What would the syntax be for the end fragment?

Put this:

Alias_Glathor.GetActorReference().SetLookAt(Alias_Engar.GetActorReference(), true)Alias_Engar.GetActorReference().SetLookAt(Alias_Glathor.GetActorReference(), true)Alias_Glathor.GetActorBase().SetInvulnerable(true)Alias_Engar.GetActorBase().SetInvulnerable(true)Alias_Glathor.GetActorReference().StartCombat(Alias_Engar.GetActorReference())Alias_Engar.GetActorReference().StartCombat(Alias_Glathor.GetActorReference())

Into the End Fragment for your Topic.

That will get the job done.

However I think it is better simply to give your quest a script, and put as much as possible of your code into that quest script, just to help keep it all in the same place, not scattered around in different fragments. That way you can keep track of, reuse, change, and add to your code much more easily.

If you give your quest a script called MyQuestScript, for example, you can call any functions in it from a scene in that quest like this:

MyQuestScript QS = (GetOwningQuest() as MyQuestScript)
QS.SomeQuestFunction()

I tried that but "GetActorBase()" wasn't recognized as a function.

However, the NPCs did fight without that.

The problem is that the scene hangs with them fighting and dialog stops.

I'm thinking the best way to tackle this is with a new quest, a fist fight quest.

Would that not allow the fight to go on while the other NPCs do their dialog, then when the time is right do a "SetStage()" to stop the fighting?

No need for that. With StartFistfight and StopFistfight functions in your quest script you can simply put a call to
RegisterForSingleUpdate(20)
at the end of StartFistfight(), and then give your quest script an OnUpdate() event like this

Event OnUpdate()   StopFistfight()EndEvent

I can promise you it works