From functional perspective Markarths house is the best. It got plenty of storage, lots of bookcases, and everything is nice and compact, also access to smelter and forge across the town.
Whiterun one is a runner up. Mostly because you get a lot of merchants in whiterun. And the enchant station is a short hop away anyways. Storage not the best and no mannequins . Best for alchemy because of the alchemy bag on the alchemy table.
However, from role playing perspective Proundspire Manor is my main "public" residence. It is very pretty decorated, but not my main house.

I'm thinking about windhelm or markath to move to they are both roomy and cozy haven't checked out riften yet
My new Housecarl is there but I haven't any use for him. I already have a companion/ follower.