Hey there again

I'd like this script to remove the book that the script is activated by when it's read by the player. It doesn't work. Can you point out the flaw, and a possible solution please?

Scriptname PerkTomeNoPrereq extends ObjectReference Perk Property TheNewPerk AutoString Property PerkTomeName AutoString Property PerkSkillName Autoint Property ReqSkillLevel Autobook Property PerkTome AutoEvent OnEquipped(Actor akActor)If akActor == Game.GetPlayer()  if Game.GetPlayer().GetBaseActorValue(PerkSkillName) >= ReqSkillLevel   if Game.GetPlayer().HasPerk(TheNewPerk) == False    Game.GetPlayer().AddPerk(TheNewPerk)    Debug.MessageBox("You have learned an advanced " + PerkSkillName + " technique: " + PerkTomeName)    Game.GetPlayer().RemoveItem(PerkTome, 1)   else    Debug.MessageBox("You already know " + PerkTomeName)   endif  else   Debug.MessageBox("Your " + PerkSkillName + " skill is too low to learn this advanced technique.")  endifendifEndEvent

Also, where can you find more examples for functions besides Creationkit.com?

Thank you very much!

Sounds like you want to hook the http://www.creationkit.com/OnRead_-_ObjectReference event instead of OnEquipped. Other than that, this should do it ...

event OnRead()	Game.GetPlayer().RemoveItem(self.GetBaseObject(), 1)endevent

As for other sources for documentation besides CreationKit.com, I doubt there are any, also IMO there shouldn't be -- It's a wiki.

Thank you very much

But it doesn't This tome script is a pain in the butt
PS.: I did change the event to onread() too..

Aside from the wiki, the source files of Skyrim itself will be the best place to look for examples of functions.

As for your script, does this work?

Event OnRead()	Wait(0.1)	Game.GetPlayer().RemoveItem(GetBaseObject(), 1)EndEvent

Cipscis

I'm using those as well, but it's sometimes hard to find the right context for the functions.


Nope :\

Okay, I thought making the game wait until the menus were all exited before attempting to remove the book might help, but I guess not.

Try putting a http://www.creationkit.com/Notification_-_Debug call in there, just to make sure that the event is actually being called.

Cipscis

Actually there's a Debug.Messagebox right above

Game.GetPlayer().RemoveItem(GetBaseObject(), 1)

in my script. It shows up. Everything else in the script works except the line where I want to remove the book.

Ah sorry, of course it doesn't work...that was rather naive of me.

Now after a few tries and CTDs, I can say this seems harder than I though it would be.
Okay, I'm gonna find a way. Found it.

Edit: So I got it working, there is one minor caveat. The book has to be a "learn spell" type book (maybe skill works too, didn't test that) otherwise Skyrim will happily crash. That means the player will get a notification message that he or she just learned a new spell...

Anyway here are the steps:

• Since you need a spell to learn, create an new ability spell, and a corresponding magic effect, the MGEF should be doing this:
  

  									scriptname RemoveSpellMagicEffect extends ActiveMagicEffect				{Removes a specific spell from the player}								;/////////////////////////////////////////////////////////////////////////////		/ Properties				/////////////////////////////////////////////////////////////////////////////;				  							Spell property BoundSpell = none auto				{REQUIRED -- bind via CK to MGEF}											;/////////////////////////////////////////////////////////////////////////////				/ Events				/////////////////////////////////////////////////////////////////////////////;								event OnEffectStart(Actor unusedTarget, Actor unusedCaster)					if (BoundSpell != none && Game.GetPlayer().HasSpell(BoundSpell))						Game.GetPlayer().RemoveSpell(BoundSpell)					endif				endevent				

  
  
• Make sure you set the BoundSpell property to the spell executing the script.
  
• create your book, and set to be a learn spell then set the learned-spell to the one you created in step 1, then attach this script:
  

  				scriptname PerkTome extends ObjectReference				{NOTE: The book this script is bound to must be a "learn spell" type book!!!}								;/////////////////////////////////////////////////////////////////////////////					/ Properties				/////////////////////////////////////////////////////////////////////////////;						Book property BoundBook auto				{REQUIRED -- has to be bound via the CK}						Perk property BoundPerk auto				{REQUIRED -- has to be bound via the CK}									;/////////////////////////////////////////////////////////////////////////////				/ Events				/////////////////////////////////////////////////////////////////////////////;						event OnEquipped(Actor unusedSource)					Actor p = Game.GetPlayer()					if (BoundPerk != none && p.HasPerk(BoundPerk) == false)						p.AddPerk(BoundPerk)					endif									if (BoundBook != none && p.GetItemCount(BoundBook) > 0)						p.RemoveItem(BoundBook, 1)					endif				endevent	

• profit.

Ahh...why does the forum have to screw with the formatting?! Any tips which to use tabs or spaces, if spaces how many? And line endings, \r, \n or \r\n or maybe the unicode ones?

In total that makes, two little scripts, one useless spell and one somewhat less useless magic effect, plus the book of course.

Edit: somewhat better to read http://pastebin.com/eXrtMtSp also I removed the BoundBook property as the book will be removed anyway if its a learn-spell book.

Push as edits don't seem to cause the forum to notify anyone?

Thank you so much! I'm currently at work, but I'll add this in as soon as I'm home.

I've got it to work in my original script Yay!

Scriptname PerkTomeNoPrereq extends ObjectReference  Perk Property TheNewPerk AutoString Property PerkTomeName AutoString Property PerkSkillName Autoint Property ReqSkillLevel Autobook Property PerkTome AutoEvent OnRead()if Game.GetPlayer().GetBaseActorValue(PerkSkillName) >= ReqSkillLevelif Game.GetPlayer().HasPerk(TheNewPerk) == FalseDebug.MessageBox("You have learned an advanced " + PerkSkillName + " technique: " + PerkTomeName)Game.GetPlayer().AddPerk(TheNewPerk)Game.GetPlayer().RemoveItem(PerkTome, 1) elseDebug.MessageBox("You already know " + PerkTomeName)endifelseDebug.MessageBox("Your " + PerkSkillName + " skill is too low to learn this advanced technique.")endifEndEvent

No CTD, No problem. I only have to update EVERY tome in my mod with the property data for the PerkTome variable.
Xetrill, thanks very much for your time and help! It's much appreciated!