Hey guys,

I have a mod in the works which requires quite some scripting. Most of it is done, however, I am having a few bugs. I'll explain in detail what the purpose of this all is.

I wanted to create a container, which you can pick up and take with you and drop and use as a container again everywhere you want. This container gets gold added every day, which you can take out of the container. But I don't want players to be able to add items to the container, except for gold.

The way I tried to do this, using the Bag of Holding mod as an example, was creating the container and adding a script to it. Next I created a misc item with a script attached to it. Then I put the container in the world and named the reference MyContainerREF. I also created three messages, one call MyMessage acting as a menu, which activates when trying to open the container, asking the player if he/she wants to open the container or take it. Next message, called MyGrabMessage, is shown once, explaining to the player that using the grab key on the container will make it show the menu again, allowing you to take it. Last message, called MyNoItemsMessage, is a notification which is shown when the player tries to add anything but gold to the container. Lastly, I created a quest which handles the adding of gold to the container.

Now, I've a few bugs going on here and that's where I need help. The container works fine the first time you take it, showing the menu, being able to take out gold and being able to take the container, which adds the misc item to your inventory and disables the container. However, despite me trying and although the notification works, you can still add items to the container. This is the first bug. The second bug involves dropping the misc item and using the container again. When dropping the misc item, the misc item gets removed from the world and the container is moved to the player and enabled. However, sometimes it stays invisible and most of the time it is or floating in mid air, or it's stuck halfway in the ground. When this happens, sometimes the menu still works, but most of the time it doesn't work anymore, you can't take it or open it and it will often go invisible. So it's bugged. I've added all the code I used on here, and put comments next to the sections that don't work or don't work correctly. The first script is the script on the container, the next script is the script on the misc item. I am totally clueless on what's causing these problems and I would really appreciate any help you guys can give me. Thanks in advance.

Also, I'm mainly looking for suggestions on how to prevent items to be added in a container and how to move the container in a way that it doesn't get stuck in midair or in in the ground. Maybe PlaceAtMe is a better way then moveto? But the most important thing is to fix the swapping between container and misc item not working.



Also, I'm mainly looking for suggestions on how to block items being added to the container, except for gold, and on how to move the container to the player in such a way, it doesn't get stuck in the ground or floats in midair.Also, I'm mainly looking for suggestions on how to block items being added to the container, except for gold, and on how to move the container to the player in such a way, it doesn't get stuck in the ground or floats in midair.
The container script:

Scriptname MyContainerScript extends ObjectReferenceInt iCount = 0Int iButton = 0Int bMessage = 0Int bShowOnce = 1MiscObject Property MyMiscItem AutoMiscObject Property Gold AutoMessage Property MyMessage AutoMessage Property MyGrabMessage AutoMessage Property MyNoItemsMessage AutoEvent OnGrab()bMessage = 1BlockActivation(True)EndEvent;===========================================Event OnActivate(ObjectReference akActionRef)If akActionRef == Game.GetPlayer()If Game.GetPlayer().GetItemCount(MyMiscItem)BlockActivation(False)ElseIf bMessageiButton = MyMessage.Show()If (iButton == 0) ; OpenBlockActivation(False)Activate(Game.GetPlayer())bMessage = 0If bShowOncebShowOnce = 0MyGrabMessage.Show()												 ;<- This does not workEndIfElseIf (iButton == 1) ; TakeDisable()bMessage = 1Game.GetPlayer().AddItem(MyMiscItem, 1)BlockActivation(False)EndIfEndIfEndIfEndEvent;==========================================Event OnItemAdded(Form akBaseItem, int aiItemCount, ObjectReference akItemReference, ObjectReference akSourceContainer)		  ;This event does not work, except for the messageIf (akBaseItem == Gold)ReturnElseif (akBaseItem != Gold)RemoveItem(akItemReference, aiItemCount)Game.GetPlayer().AddItem(akItemReference, aiItemCount, True)MyNoItemsMessage.Show()EndifIf (akBaseItem == MyMiscItem)RemoveItem(MyMiscItem, aiItemCount)Game.GetPlayer().AddItem(MyMiscItem, aiItemCount, True)EndIfEndEvent

The misc item script:

Scriptname MyMiscItemScript extends ObjectReferenceInt iCountObjectReference Property MyContainerREF AutoMiscObject Property MyMiscItem AutoEvent OnContainerChanged(ObjectReference akNewContainer, ObjectReference akOldContainer)If akNewContainerIf akOldContainerIf (akOldContainer == Game.GetPlayer())akOldContainer.RemoveItem(MyMiscItem, 1, True, akOldContainer)EndIfElseIf (akNewContainer == Game.GetPlayer())iCount = akNewContainer.GetItemCount(MyMiscItem)If (iCount > 0)iCount -= 1akNewContainer.RemoveItem(MyMiscItem, iCount, True)EndIfEndIfElseIf !akNewContainerIf MyContainerREF.IsDisabled()   MyContainerREF.Enable()EndIf  MyContainerREF.MoveTo(Self)Disable()Delete()EndIfEndEvent

Bump. Please people, I am completely stuck. I know it is a lot to read, but any assistance is appreciated!

I'm no scripting pro but my advice would be to check out http://www.creationkit.com/States_%28Papyrus%29, seems like they would be useful for what your trying to accomplish. Also check out the RemovableTorchSconce01SCRIPT which uses STATES a great deal.

Thanks for the suggestion, but that would mean rewriting the whole script and I don't know if STATE is usable in this case. Unfortunately, documentation is a little sparse at the moment. But I'll look into it. In the meantime, any other suggestions?

I'm sorry for another bump, but I really need help!

Currently going through it... A few things I've noticed: You're using integers as booleans. While the effect remains the same, it's considered good practice to use booleans where they should be used (unless there's a good reason to do otherwise). There's also the possibility of the compiler performing optimizations if the variable is a boolean.

For this part:

If (akBaseItem == Gold)  ReturnElseif (akBaseItem != Gold)  RemoveItem(akItemReference, aiItemCount)  Game.GetPlayer().AddItem(akItemReference, aiItemCount, True)  MyNoItemsMessage.Show()EndIf

Simply doing

If(akBaseItem != Gold)  RemoveItem(akItemReference, aiItemCount)  Game.GetPlayer().AddItem(akItemReference, aiItemCount, True)  MyNoItemsMessage.Show()EndIf

should suffice.

That's what I found at first glance for the first script... Gonna look through the second one now. Question first! For the second script, is it attached to MyMiscItem? If so, you don't need it as a property; you can use Self to reference it.

Edit: Also, using http://www.creationkit.com/Notification_-_Debug and http://www.creationkit.com/MessageBox_-_Debug are good ways of finding out which parts of your script are being executed.

Edit2: Crap. Misread one part. Removed it.

Edit3: This bit:

If Game.GetPlayer().GetItemCount(MyMiscItem)  BlockActivation(False)

What are you comparing it to?

Edit4: Your MiscObject properties would be better declared as Form imo. Gonna look through the second script tomorrow... Got distracted and now my roommates are bugging me to hang out.