1: When you invest you give THEM 500 gold, but their available gold each day is increased by 500 permanently, allowing you to sell more crap to them than you would otherwise. While technically this isn't a "profit" it does save you travelling as much to offload your loot.
2: Your investment makes no odds to how much you get back from your husband/wife's store each day. You do not get any money back from stores you invest in, rather the store is better able to buy items from you
3: Undoubtedly a bug, 10,000 is a phenomenally large sum
Thank you,
Ryuujin_0.
The 10K trader has been a thing in the elder scrolls before. It's very much intended if it's to believe that "He's quite the creeper" or however that dialogue is supposed to go

But it's bugged because if you invest in the sister, both of them have their available money improved (yet you cant invest in lucan) and, if you invest in him instead of her, only his is improved and her's can't be improved.
Lucan Valerius's sister, Camilla Valerius, cannot be traded in Riverwood Trader, can she?
Are you talking about when she was married to you? It would make more sense for her Store not to be upgraded like her brother, Lucan Valerius, if she is already married.