Depends on the game, really. Although I tend to prefer ranged/sneaky/kill it with fire types. Basically, so long as I get the first hit (or two, or three, or four) in a fight, I'm happy.

My primary character in LotRO is a Hunter (ranged DPS), and in the TES games I've always done a spellsword character--sneaky magic, knife in the dark types--or ranged DPS again.
I'm not a very confrontational person IRL, so I guess being a sneaky, ranged style character in games just suits me best.

Being a magic-based character is an extra perk. I feel like I'm not killing my enemies efficiently enough if I'm not also setting them on fire.

I've been playing TF2 a lot lately, and there I've found I actually do fairly well as traditional "tank" classes like the Heavy. I still prefer something a little more flexible/defensive-based, though, like Engineer or Soldier. But with that game I usually find myself switching up what character I pick depending on the map, game mode, and what the other players on my team do. Maybe I'd like to be Sniper or something, but if I'm on a team with no Engineers on Capture the Flag, you bet I'm going to be an Engineer instead. Not getting team-wiped trumps personal class preference for me in that game.