I'm working on a teleport spell, and learning Papyrus along the way, so basically the spell lets you teleport inside a house that can be owned and purchased by the player. What I would like to do is when a player clicks to teleport to the house it calls for a check if the player actually owns the house and if he does, teleports him, if not a Debug.MessageBox pops up saying like "You need to own the house first!" Should I use Functions? Or something else?

you can try using a condition:

GetVMQuestVariable HousePurchase, :SolitudeHouseVar_var == 1.00


this checks whether Proudspire Manor was purchased or not. a value of 1.00 means purchased, and 0 is not purchased.

I see. I would need to add an ObjectReference property for HousePurchase to link it to the quest itself right?

Not an 'objectReference', you would add a 'quest' object property. And link it to the quest mentioned by Amethyst above.

Never mind, got it.

Though now when I add the GetVMQuestVariable HousePurchase, :SolitudeHouseVar_var == 1.0 I get this error when compiling.

H:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\zSpellTomeTeleport.psc(34,34): no viable alternative at character ':'
H:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\zSpellTomeTeleport.psc(34,32): required (...)+ loop did not match anything at input ','

can you post the code using the code brackets

Sure. Though be aware, the code is properly structured in Sublime Text 2, but when I pasted in this damn forum, it goes [censored] all.

Scriptname zSpellTomeTeleport extends activemagiceffect{Teleport to a city of your choice and then back to where you were};PropertiesObjectReference property WhiterunBreezehome autoObjectReference property WhiterunMarketplace autoObjectReference property WhiterunJorrvaskr autoObjectReference property WhiterunSkyforge autoObjectReference property WhiterunDragonsreach autoObjectReference property SolitudeMainGate autoObjectReference property SolitudeCourtyard autoObjectReference property SolitudeProudspire autoObjectReference property SolitdueBluePalace autoObjectReference property DawnstarWindspeakInn autoObjectReference property TeleTarget auto   ;The XMarkerHeading that gets recalled to players locationMessage property QuestionMSGR auto   ;Points to RecallMessage property QuestionMSGM auto   ;Points to Mainbox, containing all the cities the player is able to choose fromMessage property QuestionMSGWR auto   ;Points to Whiterun locations question boxMessage property QuestionMSGS auto   ;Points to Solitude locations question boxMessage property QuestionMSGD auto   ;Points to Dawnstar locations question boxQuest property HousePurchase autoGlobalVariable property SpellSwitch auto;FunctionsFunction MessageBox(string asMessageBoxText) native global  ;Function to show debug message box in gameFunction Notification(string asNotificationText) native global  ;Function to debug the script in gameFunction Teleport(actor source, ObjectReference destination)  TeleTarget.MoveTo(source)Utility.Wait(0.2)casterRef.MoveTo(destination)SpellSwitch.SetValueInt(1)endfunctionActor casterObjectReference casterRef  int Recall   ;The return question box(offered when the spell has already been used once before.)int Mainbox   ;The main question box, containing all the cities to choose fromint Whiterun   ;The Whiterun locations question boxint Solitude   ;The Solitude locations question boxint Dawnstar   ;The Dawnstar locations question boxint mySpellSwitchEvent OnEffectStart(Actor akTarget, Actor akCaster)    caster = akCaster	     casterRef = (caster as ObjectReference)mySpellSwitch = SpellSwitch.GetValueInt()     if mySpellSwitch == 1	 Utility.Wait(0.3)   ;Waits 0.3 seconds	  SpellSwitch.SetValueInt(0)	  Recall = QuestionMSGR.Show()	 if Recall == 0	   casterRef.MoveTo(TeleTarget)	   elseif Recall == 1	   QuestionMSGM.Show()	    endif	    else   Utility.Wait(0.5)  Mainbox = QuestionMSGM.Show()   ;Shows the main location box with the cities    if Mainbox == 0  	 Whiterun = QuestionMSGWR.Show()   ;Shows Whiterun locations question box	 Utility.Wait(0.2)	    if Whiterun == 0	 GetVMQuestVariable HousePurchase, :SolitudeHouseVar_var == 1.00    Teleport(caster, WhiterunBreezehome)   	  elseif Whiterun == 1    Teleport(caster, WhiterunMarketplace)	  elseif Whiterun == 2    Teleport(caster, WhiterunJorrvaskr)	 elseif Whiterun == 3    Teleport(caster, WhiterunSkyforge)	 elseif Whiterun == 4    Teleport(caster, WhiterunDragonsreach)	    endif	   endif   if Mainbox == 1   Solitude = QuestionMSGS.Show()   ;Shows Solitude locations question box   Utility.Wait(0.2)      if Solitude == 0    Teleport(caster, SolitudeMainGate)	 elseif Solitude == 1    Teleport(caster, SolitudeCourtyard)	 elseif Solitude == 2    Teleport(caster, SolitudeProudspire)	  elseif Solitude == 3    Teleport(caster, SolitdueBluePalace)		    endif  endif   if Mainbox == 2   Dawnstar = QuestionMSGD.Show()   ;Shows Dawnstar locastions question box   Utility.Wait(0.2)    if Dawnstar == 0    Teleport(caster, DawnstarWindspeakInn)	 	  endif	  endifendifEndEvent

if whiterun == 0 && getvmquest blah blah

try that instead of putting it inside the if statement. because you need both of them to be true, so they should both be in the conditional.

Doing that gave these errors.

H:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\zSpellTomeTeleport.psc(66,55): no viable alternative at character ':'
H:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\zSpellTomeTeleport.psc(66,21): required (...)+ loop did not match anything at input 'GetVMQuestVariable'
H:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\zSpellTomeTeleport.psc(66,53): required (...)+ loop did not match anything at input ','

it could also be that getvmquestvariable is only related to dialog.

try this one instead: http://www.creationkit.com/GetQuestVariable

Doesn't seem to work. We're probably missing something.

Could you check to see if the door on the house is locked or not?
If its locked, the player probably does not own it yet and has not visited it.

http://www.creationkit.com/GetLockLevel_-_ObjectReference

That's not really what I need. I just need a check that would tell the script if the player OWNS the house or not. If he doesn't, it doesn't let him teleport inside. If he does, it lets him.

Well, that is exactly what a check on the door being locked would do. If you own and have visited your house, the door will be unlocked. Otherwise the door is still 'key locked'.
You could check for the key in the players inventory instead. They get the key when they get the house.

GetVMQuestVariable is a condition function, not a papyrus one
Seriously if you don't know what you're talking about you're doing worse than not helping

Ah, yes. Good idea. That should be simpler to do. I'll look into it.

I also had this idea, you beat me to it; however I was thinking that it may be possible to drop the key once the house has been visited and it would no longer be a quest item.... I know it's unlikely that a player would drop the key for any reason but I suppose you gotta consider every possibility.

Yes, true. That's why I wanted to run a check if the player owns the house but not by checking if the door is locked or if the player owns the key. I think it would be possible to check the ownership of it through the script. Perhaps maybe check to see if PlayerFaction is Owner of the house? Since when you buy it, it sets the ownership to PlayerFaction. Though, I gotta figure out how.

Edit: Or maybe even use this http://www.creationkit.com/GetActorOwner_-_ObjectReference

cell Property cellInterior  Auto	;set this property to the cell in question, eg. WhiterunBreezehomefaction Property factionPlayer auto  ;set this to the PlayerFaction factionif (cellInterior.GetFactionOwner() == factionPlayer)   ;do stuff hereendif

That will work on the 5 existing houses - it'll be up to you to set the owner faction for the cell if it's a new house.

Thank you! I will check it out as soon as I can.

I don't think this is a good solution, since you can just unlock the door by opening the console command prompt, select the door and type "Unlock" to unlock the door without having the key.

Thanks a bunch, that worked perfectly! I now have only one minor issue. Since I've put a Debug.MessageBox("You need to own the house first!") to show if you don't own it, and it DOES show that, so that's fine, but the problem is, if I teleport to the location right after the Breezehome in the list of locations, I get the Debug messagebox again.

Here's the part of the script with Whiterun.

if Mainbox == 0  	 Whiterun = QuestionMSGWR.Show()   ;Shows Whiterun locations question box	 Utility.Wait(0.2)	if Whiterun == 0 && WhiterunCell.GetFactionOwner() == FactionPlayer	   Teleport(caster, WhiterunBreezehome)	    elseif Debug.MessageBox("You need to own the house first!")elseif Whiterun == 1	   Teleport(caster, WhiterunMarketplace)elseif Whiterun == 2	  Teleport(caster, WhiterunJorrvaskr)elseif Whiterun == 3	   Teleport(caster, WhiterunSkyforge)elseif Whiterun == 4	   Teleport(caster, WhiterunDragonsreach)   	endif	   endif

if Whiterun == 0   if WhiterunCell.GetFactionOwner() == FactionPlayer	  Teleport(caster, WhiterunBreezehome)   else	  Debug.MessageBox("You need to own the house first!")   endifelseif   whiterun == 1;followed by the rest of the "elseif"s

Not sure about using the debug stuff tho - requires an ini change to work which other users may not have.

Thanks. And what do you mean it requires an ini change to work? I did not touch anything Debug related in my ini file, yet it still works O.o Though I could always use a Message property for it.